Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for patch release tags. #1246

Merged
merged 22 commits into from
Jul 22, 2024

Conversation

joshuabaird
Copy link
Collaborator

@joshuabaird joshuabaird commented Jul 17, 2024

What this PR does / why we need it:

Introduces the ability to release "patch" builds (eg, fluent-bit:3.1.2-2) of fluent-bit/fluentd. This allows us to release changes to our custom builds without overwriting tags that track upstream versions (eg, fluent-bit:3.1.2).

Which issue(s) this PR fixes:

Fixes #1241

These workflows were tested successfully in my fork of the repo.

Does this PR introduced a user-facing change?

N/A

Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
Signed-off-by: Josh Baird <[email protected]>
tags: |
type=raw,value=${{ github.event.inputs.docker_tag_version }}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a duplicate step that is not necessary.

@joshuabaird joshuabaird marked this pull request as ready for review July 18, 2024 17:49
Signed-off-by: Josh Baird <[email protected]>
@benjaminhuo
Copy link
Member

That's a great enhancement, thanks @joshuabaird !

@benjaminhuo benjaminhuo merged commit eeb5bfd into fluent:master Jul 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support out-of-band image updates for fluentd and fluentbit
3 participants