Fix service monitor label selector scope #1284
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This block in the service monitor fails to correctly use the
with
context:As a result, populating
.Values.fluentbit.labels
results in:Helm install failed for release monitoring/fluent-operator with chart [email protected]: template: fluent-operator/templates/fluentbit-servicemonitor.yaml:34:24: executing "fluent-operator/templates/fluentbit-servicemonitor.yaml" at <.Values.fluentbit.labels>: nil pointer evaluating interface {}.fluentbit
Which issue(s) this PR fixes:
None, can create an issue if necessary
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: