BUG: re-add accidently removed flag.Parse #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Batuhan Apaydin <[email protected]>
developer-guy
changed the title
|
kindly ping @benjaminhuo |
benjaminhuo
reviewed
Aug 12, 2024
| @@ -72,6 +72,8 @@ func main() { | |||
| level.Warn(logger).Log("--flb-timeout is deprecated. Consider setting the terminationGracePeriod field on the `(Cluster)FluentBit` instance.") | |||
| } | |||
|
|
|||
| flag.Parse() | |||
There was a problem hiding this comment.
Nice catch @developer-guy
cc @cw-Guo
benjaminhuo
approved these changes
Aug 12, 2024
|
Thanks @benjaminhuo, one question though, will you cut a new release with that fix included? |
|
kindly ping @benjaminhuo |
|
@developer-guy A new version is scheduled, see this issue. thanks for the good catch again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In the commit at d8e2060 I saw that someone accidentally removed the flag.Parse line, which caused fluent-watcher to ignore any CLI flag values, so I added it back
Which issue(s) this PR fixes:
Fixes re
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: