feat: Expose lua filter type_array_key parameter #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lua filter was missing a parameter `type_array_key`. I've copied the parameter description into the type comment from the fluent-bit docs. Ran `make generate manifests docs-update verify build`. Signed-off-by: Zoltán Reegn <[email protected]>
cw-Guo
previously approved these changes
Aug 23, 2024
benjaminhuo
reviewed
Aug 26, 2024
| @@ -76,12 +79,17 @@ func (l *Lua) Params(_ plugins.SecretLoader) (*params.KVs, error) { | |||
| kvs.Insert("type_int_key", strings.Join(l.TypeIntKey, " ")) | |||
| } | |||
|
|
|||
| if l.TypeArrayKey != nil && len(l.TypeArrayKey) > 0 { | |||
| kvs.Insert("type_array_key", strings.Join(l.TypeIntKey, " ")) | |||
There was a problem hiding this comment.
should be kvs.Insert("type_array_key", strings.Join(l.TypeArrayKey, " ")) ?
There was a problem hiding this comment.
ah, right, my mistake. fixing.
There was a problem hiding this comment.
@benjaminhuo please check again, now that should be fixed.
Signed-off-by: Zoltán Reegn <[email protected]>
reegnz
force-pushed
the
feat/lua_type_array_key
branch
from
2e014a9 to
c4d1cfb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lua filter was missing a parameter
type_array_key.I've copied the parameter description into the type comment from the
fluent-bit docs.
Ran
make generate manifests docs-update verify build.Signed-off-by: Zoltán Reegn [email protected]
What this PR does / why we need it
Which issue(s) this PR fixes
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc