Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add VERSION file for fluentbit image #1447

Merged
merged 4 commits into from
Jan 3, 2025

Conversation

cw-Guo
Copy link
Collaborator

@cw-Guo cw-Guo commented Jan 3, 2025

What this PR does / why we need it:

improve image build process

Which issue(s) this PR fixes:

Fixes #

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:


@cw-Guo cw-Guo marked this pull request as draft January 3, 2025 05:05
@cw-Guo cw-Guo force-pushed the feat/upgrade-fluentbit-image branch 2 times, most recently from b031e01 to 3835d1c Compare January 3, 2025 05:19
@cw-Guo cw-Guo force-pushed the feat/upgrade-fluentbit-image branch 2 times, most recently from ee1e6c5 to 3425913 Compare January 3, 2025 05:30
@cw-Guo cw-Guo force-pushed the feat/upgrade-fluentbit-image branch from 3425913 to 1d2fd5b Compare January 3, 2025 05:36
@cw-Guo cw-Guo marked this pull request as ready for review January 3, 2025 05:40
@cw-Guo
Copy link
Collaborator Author

cw-Guo commented Jan 3, 2025

@benjaminhuo I added a VERSION file to specify the fluent-bit image version so that we can avoid updating multiple places when bumpping the version.

Also removed the docker_tag_version from the workflow input, it can be read from the VERSION file.

See tests here: https://github.com/cw-Guo/fluent-operator/actions/runs/12593318269

https://github.com/cw-Guo/fluent-operator/actions/runs/12593457069/job/35099495400#step:7:183

@cw-Guo cw-Guo force-pushed the feat/upgrade-fluentbit-image branch from 4a20759 to e015cb4 Compare January 3, 2025 05:50
Signed-off-by: juicer <[email protected]>
@cw-Guo cw-Guo force-pushed the feat/upgrade-fluentbit-image branch from e015cb4 to 373dee4 Compare January 3, 2025 05:55
@benjaminhuo
Copy link
Member

cc @wanjunlei @wenchajun

@benjaminhuo benjaminhuo merged commit abccb78 into fluent:master Jan 3, 2025
6 checks passed
@benjaminhuo
Copy link
Member

@benjaminhuo I added a VERSION file to specify the fluent-bit image version so that we can avoid updating multiple places when bumpping the version.

Also removed the docker_tag_version from the workflow input, it can be read from the VERSION file.

See tests here: https://github.com/cw-Guo/fluent-operator/actions/runs/12593318269

https://github.com/cw-Guo/fluent-operator/actions/runs/12593457069/job/35099495400#step:7:183

If you search 3.1.8 globally in the code, you may found other places that need to be changed as well @cw-Guo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants