feat: add envFrom support for fluentd daemonset and statefulsets #1458
+241
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thapabishwa
force-pushed
the
feature/env-from
branch
from
e2dda6c to
366c563
Compare
Signed-off-by: Bishwa Thapa <[email protected]>
thapabishwa
force-pushed
the
feature/env-from
branch
from
366c563 to
b0a5b82
Compare
thapabishwa
changed the title
cw-Guo
reviewed
Jan 27, 2025
Signed-off-by: Bishwa Thapa <[email protected]>
thapabishwa
force-pushed
the
feature/env-from
branch
from
42dfc2e to
9dd2abf
Compare
Done. Thanks for the review. |
cw-Guo
approved these changes
Jan 29, 2025
wenchajun
approved these changes
Jan 30, 2025
|
@cw-Guo @wenchajun Any visibility on release of this feature? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds support for EnvFrom on the Fluentd CRD
Does this PR introduced a user-facing change?
Yes, this includes changes in the Fluentd CRD