CI: Check time to start service on Windows #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenhys
reviewed
Mar 26, 2024
kenhys
reviewed
Mar 26, 2024
daipom
force-pushed
the
ci-win-check-time-to-start-service
branch
from
d7516ba to
1bac946
Compare
daipom
changed the title
daipom
changed the title
kenhys
reviewed
Mar 27, 2024
kenhys
requested changes
Mar 27, 2024
daipom
force-pushed
the
ci-win-check-time-to-start-service
branch
from
1bac946 to
9c13c0c
Compare
Signed-off-by: Daijiro Fukuda <[email protected]>
daipom
force-pushed
the
ci-win-check-time-to-start-service
branch
from
9c13c0c to
97b62fe
Compare
|
Applied suggestions and rebased to the latest master. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test for
On v5.0.2, I have confirmed it takes 4.6s ~ 6.7s.
https://github.com/daipom/fluent-package-builder/actions/runs/8417853364/job/23047108305#step:7:168
On the master, it takes less than 1s.
https://github.com/daipom/fluent-package-builder/actions/runs/8417835331/job/23047050065#step:7:167