Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

system-test install-newly: remove unnecessary condition #743

Merged
merged 1 commit into from
Nov 26, 2024
Merged

system-test install-newly: remove unnecessary condition #743

merged 1 commit into from
Nov 26, 2024

Conversation

Watson1978
Copy link
Contributor

This PR will remove unnecessary condition for that it guards duplicated instance

@Watson1978 Watson1978 marked this pull request as ready for review November 25, 2024 08:11
@Watson1978 Watson1978 requested review from kenhys and daipom November 25, 2024 08:11
kenhys
kenhys approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@kenhys kenhys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

daipom
daipom approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@kenhys kenhys merged commit 9c15e3d into fluent:master Nov 26, 2024
107 checks passed
@kenhys
Copy link
Contributor

kenhys commented Nov 26, 2024

Thanks!

@Watson1978 Watson1978 deleted the system-test/install-newly branch November 26, 2024 02:05
@kenhys kenhys added this to the 5.2.0 milestone Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daipom daipom daipom approved these changes

@kenhys kenhys kenhys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Watson1978 @kenhys @daipom