Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add cache hash for msi #778

Merged
merged 1 commit into from
Jan 30, 2025
Merged

ci: add cache hash for msi #778

merged 1 commit into from
Jan 30, 2025

Conversation

daipom
Copy link
Contributor

@daipom daipom commented Jan 30, 2025

No description provided.

Signed-off-by: Daijiro Fukuda <[email protected]>
@daipom daipom requested review from kenhys and Watson1978 January 30, 2025 01:35
Copy link
Contributor

@Watson1978 Watson1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@daipom daipom added the CI label Jan 30, 2025
@daipom daipom added this to the 5.2.1 milestone Jan 30, 2025
Copy link
Contributor

@kenhys kenhys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kenhys
Copy link
Contributor

kenhys commented Jan 30, 2025

nitpick: how about including assets/*

@kenhys kenhys merged commit ab28334 into master Jan 30, 2025
206 checks passed
@kenhys kenhys deleted the ci-add-cache-hash-for-msi branch January 30, 2025 04:58
Watson1978 pushed a commit to Watson1978/fluent-package-builder that referenced this pull request Feb 3, 2025
daipom added a commit that referenced this pull request Feb 3, 2025
This is backport 778 to v5 branch.

Signed-off-by: Daijiro Fukuda <[email protected]>
Co-authored-by: Daijiro Fukuda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants