Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport(v5) msi: keep some registry values with update (#777) #779

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Backport(v5) msi: keep some registry values with update (#777) #779

merged 1 commit into from
Feb 3, 2025

Conversation

Watson1978
Copy link
Contributor

This is backport #777 to v5 branch.

This keeps the following registry values (in
HKLM\System\CurrentControlSet\Services\fluentdwinsvc) when updating:

  • Start
  • DelayedAutostart
  • fluentdopt

(ref https://wixtoolset.org/docs/v3/xsd/wix/registrysearch/) @Watson1978 found we can write such a raw value with a prefix by string Type. Thanks!

@daipom @Watson1978 @kenhys
Backport(v5) msi: keep some registry values with update (fluent#777)
3c317ec 
* Fixes fluent#602
* Another idea for fluent#776

This keeps the following registry values (in
`HKLM\System\CurrentControlSet\Services\fluentdwinsvc`) when updating:

* `Start`
* `DelayedAutostart`
* `fluentdopt`

(ref https://wixtoolset.org/docs/v3/xsd/wix/registrysearch/)
@Watson1978 found we can write such a raw value with a prefix by
`string` Type. Thanks!

Signed-off-by: Daijiro Fukuda <[email protected]>
Co-authored-by: Shizuo Fujita <[email protected]>
Co-authored-by: Kentaro Hayashi <[email protected]>
@Watson1978 Watson1978 requested review from kenhys and daipom February 3, 2025 02:43
@daipom
Copy link
Contributor

daipom commented Feb 3, 2025

Thanks! Waiting CI.

daipom
daipom approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Note: The CI failure for Amazon Linux 2023 has nothing to do with this PR.
We will handle it in another PR.

@daipom daipom merged commit b971e56 into fluent:fluent-package-v5 Feb 3, 2025
34 of 35 checks passed
@kenhys kenhys mentioned this pull request Feb 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daipom daipom daipom approved these changes

@kenhys kenhys Awaiting requested review from kenhys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Watson1978 @daipom