Skip to content

Commit

Permalink
Backport(v1.16) windows: add workaround for unexpected exception (#4747
Browse files Browse the repository at this point in the history
…) (#4800)

**Which issue(s) this PR fixes**:

Backport #4747 

**What this PR does / why we need it**:

Since logger 1.6.3 or later, there is a bug that it cause unexpected
exception (no implicit conversion of Integer into String (TypeError)) on
windows. So hold on 1.6.2 for a while.

See ruby/logger#107

**Docs Changes**:

N/A

**Release Note**:

N/A

Signed-off-by: Kentaro Hayashi <[email protected]>
  • Loading branch information
kenhys authored Jan 29, 2025
1 parent 9bea070 commit 01b3c08
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions fluentd.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@ Gem::Specification.new do |gem|
gem.add_runtime_dependency("webrick", ["~> 1.4"])
gem.add_runtime_dependency("console", ["< 1.24"])

# gems that aren't default gems as of Ruby 3.5
# logger 1.6.3 or later cause bug on windows,
# hold on 1.6.2 for a while. see https://github.com/ruby/logger/issues/107
gem.add_runtime_dependency("logger", ["1.6.2"])

# build gem for a certain platform. see also Rakefile
fake_platform = ENV['GEM_BUILD_FAKE_PLATFORM'].to_s
gem.platform = fake_platform unless fake_platform.empty?
Expand Down

0 comments on commit 01b3c08

Please sign in to comment.