Skip to content

Commit

Permalink
test: use IO#popen instead of Kernel#open
Browse files Browse the repository at this point in the history
open("|command") spawns command and create pipes for
processing pipeline.

This feature of Kernel#open is deprecated, replace it with
IO#popen.

It fixes the following warning:

  warning: Calling Kernel#open with a leading '|' is deprecated and will
  be removed in Ruby 4.0; use IO.popen instead

Signed-off-by: Kentaro Hayashi <[email protected]>
  • Loading branch information
kenhys committed Dec 27, 2023
1 parent d086b29 commit 6d76370
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions test/plugin_helper/test_child_process.rb
Original file line number Diff line number Diff line change
Expand Up @@ -559,7 +559,7 @@ def configure(conf)
unless Fluent.windows?
test 'can specify subprocess name' do
io = IO.popen([["cat", "caaaaaaaaaaat"], '-'])
process_naming_enabled = (open("|ps opid,cmd"){|_io| _io.readlines }.count{|line| line.include?("caaaaaaaaaaat") } > 0)
process_naming_enabled = (IO.popen(["ps", "opid,cmd"]){|_io| _io.readlines }.count{|line| line.include?("caaaaaaaaaaat") } > 0)
Process.kill(:TERM, io.pid) rescue nil
io.close rescue nil

Expand All @@ -576,7 +576,7 @@ def configure(conf)
m.lock
ran = true
pids << @d.child_process_id
proc_lines += open("|ps opid,cmd"){|_io| _io.readlines }
proc_lines += IO.popen(["ps", "opid,cmd"]){|_io| _io.readlines }
m.unlock
readio.read
end
Expand Down Expand Up @@ -635,8 +635,8 @@ def configure(conf)
unless Fluent.windows?
test 'can change working directory' do
# check my real /tmp directory (for mac)
cmd = %[|ruby -e 'Dir.chdir("/tmp"); puts Dir.pwd']
mytmpdir = open(cmd){|io| io.read.chomp }
cmd = ['ruby', '-e', 'Dir.chdir("/tmp"); puts Dir.pwd']
mytmpdir = IO.popen(cmd){|io| io.read.chomp }

m = Mutex.new
str = nil
Expand Down

0 comments on commit 6d76370

Please sign in to comment.