Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_in_tail: fix flaky tests for file rotation #4710

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

Watson1978
Copy link
Contributor

@Watson1978 Watson1978 commented Nov 19, 2024

Which issue(s) this PR fixes:
Fixes #4707

What this PR does / why we need it:
This PR will fix unstable tests.

Docs Changes:

Release Note:

Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! Great!!

test/plugin/test_in_tail.rb Outdated Show resolved Hide resolved
test/plugin/test_in_tail.rb Outdated Show resolved Hide resolved
@Watson1978 Watson1978 marked this pull request as ready for review November 20, 2024 00:30
@Watson1978 Watson1978 requested a review from daipom November 20, 2024 00:31
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@daipom daipom merged commit 2b33a69 into fluent:master Nov 20, 2024
15 of 16 checks passed
@Watson1978 Watson1978 deleted the fix-test_in_tail branch November 20, 2024 02:14
@daipom daipom added the backport to LTS We will backport this fix to the LTS branch label Nov 29, 2024
@daipom daipom added this to the v1.18.0 milestone Jan 28, 2025
kenhys pushed a commit that referenced this pull request Jan 29, 2025
* test_in_tail: fix flaky tests for file rotation

Signed-off-by: Shizuo Fujita <[email protected]>

* test_in_tail: remove unnecessary inode assertions

Signed-off-by: Shizuo Fujita <[email protected]>

---------

Signed-off-by: Shizuo Fujita <[email protected]>
Signed-off-by: Kentaro Hayashi <[email protected]>
daipom pushed a commit that referenced this pull request Jan 29, 2025
… (#4795)

**Which issue(s) this PR fixes**: 

Backport #4710 

**What this PR does / why we need it**: 

This PR will fix unstable tests.

* test_in_tail: fix flaky tests for file rotation
* test_in_tail: remove unnecessary inode assertions

**Docs Changes**:

**Release Note**:

Signed-off-by: Shizuo Fujita <[email protected]>
Signed-off-by: Kentaro Hayashi <[email protected]>
Co-authored-by: Watson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport to LTS We will backport this fix to the LTS branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Flaky "test_next_rotation_occurs_very_fast_while_old_TW_still_waiting_rotate_wait" test
2 participants