Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport(v1.16) command: fix NoMethodError of --daemon under Windows #4796

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

kenhys
Copy link
Contributor

@kenhys kenhys commented Jan 29, 2025

Which issue(s) this PR fixes:

Backport #4716

What this PR does / why we need it:
To daemonize the process, the following code will be invoked on Windows:

ServerEngine::Daemon.run_server(server_module, worker_module) { Fluent::Supervisor.serverengine_config(params) }

$log variable does not exist because it has not executed Superviser#setup_global_logger method until here.
It will perform a new startup process and prepare a logger in

ServerEngine::Daemon.run_server(server_module, worker_module) { Fluent::Supervisor.serverengine_config(params) }

This patch will only avoid the error since a logger is not required this process.

Docs Changes:
Not needed.

Release Note:
The same as the title.

Signed-off-by: Shizuo Fujita <[email protected]>
Signed-off-by: Kentaro Hayashi <[email protected]>
@kenhys
Copy link
Contributor Author

kenhys commented Jan 29, 2025

git switch -c backport-pr4716 --track origin/v1.16
git cherry-pick 713b738d9ac4a9321bbeb550b415311a6478747b

@daipom daipom added this to the v1.16.7 milestone Jan 29, 2025
@daipom daipom merged commit fc5ece8 into v1.16 Jan 29, 2025
11 of 16 checks passed
@daipom daipom deleted the backport-pr4716 branch January 29, 2025 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants