Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPII-3640 minor changes to run in electron #27

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sgithens
Copy link
Contributor

This clearly isn't ready for merging, but opening this to document the changes I needed to make.

@the-t-in-rtf the-t-in-rtf self-assigned this Apr 17, 2019
@the-t-in-rtf
Copy link
Collaborator

the-t-in-rtf commented Apr 17, 2019

@sgithens, sorry for the extreme delay. The logical next step here to me is to add electron as a dev dependency and add a test that exercises the package in electron. We'd then want to work through errors related to each of the two bits you had to comment out. One (the fluid require) seems like something on the server side needs to be moved to the "common" or "client" side. No idea about the other, but tests would certainly make it clear what you're trying to do and give us a consistent error to talk about.

@gpii-bot
Copy link

@the-t-in-rtf
Copy link
Collaborator

@sgithens, I have been working to fix the CI config for this project. If you merge with master and commit, you should have everything you need to run tests against your work.

@the-t-in-rtf
Copy link
Collaborator

If this is still relevant, please update to reflect current master and I promise I'll review much more quickly.

@jobara jobara changed the base branch from master to main October 22, 2020 17:21
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants