Add and update consensus configuration options #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Being based on top of feature/where-syntax-update which still has the failing policy test. Once that passes this should pass. |
Base automatically changed from
feature/where-syntax-update
to
feature/subscription
November 6, 2023 16:04
cap10morgan
reviewed
Nov 8, 2023
Comment on lines
+177
to
+178
| (log/warn "LOG PATH: " log-path) | ||
| (log/warn "CONN STORAGE PATH: " conn-storage-path) |
There was a problem hiding this comment.
Do we want these logged at the warn level? Or at all here?
cap10morgan
reviewed
Nov 8, 2023
Comment on lines
+185
to
+186
| (log/warn "LOG PATH*: " log-path*) | ||
| (log/warn "CONN STORAGE PATH*: " conn-storage-path*) |
There was a problem hiding this comment.
Do we want to leave these log messages in?
cap10morgan
reviewed
Nov 8, 2023
| "If conn method is :file or :memory, returns false, else true." | ||
| [conn] | ||
| (let [method (conn-proto/-method conn)] | ||
| (if (#{:file :memory} method) |
There was a problem hiding this comment.
Can we reference this set from a shared ns? I see it's defined as fluree.server.components.consensus/replicate-file-conn-types, but not sure if we can access that here w/o a circular ref.
cap10morgan
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This primarily adds additional consensus configuration options and provides documentation for them.
The default logging directory now has some additional logic to str/replace the '/' in the multi-address format to '-' such that a deeply nested directory is not created.