Correct clj-kondo errors and warnings #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 18, 2023
Merged
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
This was referenced Dec 18, 2023
Merged
zonotope
reviewed
Dec 19, 2023
| :tx-id tx-id | ||
| :ledger-id ledger-id | ||
| :instant (System/currentTimeMillis)}) | ||
| '{:txn txn |
There was a problem hiding this comment.
should this map really be quoted? there are a bunch of function calls inside.
There was a problem hiding this comment.
It's quoted because most of the symbols inside are not resolvable, which clj-kondo flags. It's just a commented-out example anyway.
| @@ -11,6 +11,7 @@ | |||
| res))) | |||
|
|
|||
| (defmacro defhandler | |||
| {:clj-kondo/lint-as 'clojure.core/defn} | |||
There was a problem hiding this comment.
there might not be a way around it, but i'm not a big fan of annotations for external tooling in code. i'd prefer that this kind of stuff go in a separate config file if possible.
There was a problem hiding this comment.
Yeah I think there's a way to do that. I'll look into it.
cap10morgan
force-pushed
the
12-18-Correct_clj-kondo_errors_and_warnings
branch
from
a5c6e7e to
ceae096
Compare
Merge activity
|
cap10morgan
force-pushed
the
12-18-Add_cljfmt_check_in_CI_pipeline
branch
from
63e5055 to
c7485ef
Compare
cap10morgan
force-pushed
the
12-18-Correct_clj-kondo_errors_and_warnings
branch
from
ceae096 to
4ed4786
Compare
cap10morgan
force-pushed
the
12-18-Add_cljfmt_check_in_CI_pipeline
branch
from
c7485ef to
7e26c94
Compare
cap10morgan
force-pushed
the
12-18-Correct_clj-kondo_errors_and_warnings
branch
from
4ed4786 to
826f749
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.