Skip to content

Commit

Permalink
Add TODO for start position
Browse files Browse the repository at this point in the history
  • Loading branch information
xiaowei-guan committed Nov 28, 2024
1 parent 1063348 commit d68e0b1
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions packages/video_player_avplay/tizen/src/plus_player.cc
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,10 @@ int64_t PlusPlayer::Create(const std::string &uri,
int64_t start_position = flutter_common::GetValue(
create_message.player_options(), "startPosition", (int64_t)0);
if (start_position == 0) {
// if startPosition is in the range of int32_t, it will convert as int32_t.
// if startPosition >= INT32_MAX, it will convert as int64_t.
// TODO we will implement a new function for long type, no need call two
// times.
start_position = flutter_common::GetValue(create_message.player_options(),
"startPosition", (int32_t)0);
}
Expand Down

0 comments on commit d68e0b1

Please sign in to comment.