[local_auth_darwin] Handle when FaceID hardware is available but permissions have been denied for the app #8348
+30
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
changed the title
jmagman
force-pushed
the
local-auth-not-available
branch
from
f1a3d67 to
cafcf97
Compare
LouiseHsu
reviewed
Jan 15, 2025
|
|
||
| var error: FlutterError? | ||
| let result = plugin.deviceCanSupportBiometricsWithError(&error) | ||
| XCTAssertFalse(result!.boolValue) | ||
| XCTAssertNil(error) | ||
| } | ||
|
|
||
| func testDeviceSupportsBiometrics_withBiometryNotAvailableLoadedBiometryType() { |
There was a problem hiding this comment.
its not super clear to me what "loadedBiometryType" means in this context
maybe testDeviceSupportsBiometrics_withBiometryNotAvailableWhenPermissionsDenied?
There was a problem hiding this comment.
Sorry, I missed this comment somehow.
#8499
jmagman
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 20, 2025
…e but permissions have been denied for the app (flutter/packages#8348)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 20, 2025
…e but permissions have been denied for the app (flutter/packages#8348)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 20, 2025
…e but permissions have been denied for the app (flutter/packages#8348)
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 20, 2025
flutter/packages@f73cb00...e8f1f63 2025-01-20 [email protected] [in_app_purchase] Update Play Billing library to 7.1.1 (flutter/packages#8218) 2025-01-20 [email protected] Roll Flutter from 5517cc9 to b9e86a5 (22 revisions) (flutter/packages#8458) 2025-01-18 [email protected] [pigeon] Update analyzer and formatter (flutter/packages#8456) 2025-01-17 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump the gradle-plugin group across 3 directories with 1 update (flutter/packages#8328) 2025-01-17 [email protected] [local_auth_darwin] Handle when FaceID hardware is available but permissions have been denied for the app (flutter/packages#8348) 2025-01-16 [email protected] Roll Flutter from 40c2b86 to 5517cc9 (28 revisions) (flutter/packages#8441) 2025-01-15 [email protected] [in_app_purchase_storekit] expose `jsonRepresentation` for Transactions (flutter/packages#8430) 2025-01-15 [email protected] Roll Flutter (stable) from 17025dd to 68415ad (4 revisions) (flutter/packages#8434) 2025-01-15 [email protected] [video_player_avfoundation] fix playback speed resetting (flutter/packages#7657) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LocalAuth
-canEvaluatePolicy::returns errorLAErrorBiometryNotAvailablewhen either Face ID isn't available at the hardware level, OR the Face ID is available/setup but the permissions for the app were denied.If it returns
LAErrorBiometryNotAvailable, also checkbiometryTypesince this should be none if there really is no biometry, but gets populated withLABiometryTypeTouchIDwhen the FaceID hardware is available, but permission is denied. I tried this on a iPhone 16 Pro which has Face ID but not Touch ID support.Fixes flutter/flutter#160083
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.