Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[camera]: Activate leak testing for sub packages #8353

Merged
merged 1 commit into from
Jan 10, 2025
Merged

[camera]: Activate leak testing for sub packages #8353

merged 1 commit into from
Jan 10, 2025
+70 −0

Conversation

ValentinVignal
Copy link
Contributor

@ValentinVignal ValentinVignal commented Dec 28, 2024 •
edited
Loading

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

Follow up of #8287

Activates leak testing for the packages including a test folder

See the documentation: https://github.com/dart-lang/leak_tracker/blob/main/doc%2Fleak_tracking%2FDETECT.md

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@ValentinVignal
Copy link
Contributor Author

cc @polina-c

@ValentinVignal
Copy link
Contributor Author

Since I modified only the tests, I think this PR is eligible for the tags override: no versioning needed and override: no changelog needed

@polina-c polina-c added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Jan 3, 2025
bparrishMines
bparrishMines approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending tests

@ValentinVignal ValentinVignal added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Jan 9, 2025
@ValentinVignal
Copy link
Contributor Author

@bparrishMines when you say

pending tests

you meant that some checks failed at the time of your review? Or something else?

Everything seems green now

image

@bparrishMines
Copy link
Contributor

bparrishMines commented Jan 9, 2025 •
edited
Loading

@ValentinVignal Yes, i meant that everything LGTM assuming the tests pass on a rerun. If I remember correctly, there were tests that I reran when I reviewed. I think the repo_checks test failed initially.

@ValentinVignal
Copy link
Contributor Author

Great thank you! Just wanted to make sure before it being merged ! 👍

@ValentinVignal ValentinVignal added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 10, 2025
@auto-submit auto-submit bot merged commit 94c4a3e into flutter:main Jan 10, 2025
77 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2025
@engine-flutter-autoroll
94c4a3ee5 [camera]: Activate leak testing for sub packages (flutter/p…
f53d864 
…ackages#8353)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2025
@engine-flutter-autoroll
94c4a3ee5 [camera]: Activate leak testing for sub packages (flutter/p…
b65e545 
…ackages#8353)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 13, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 13, 2025
@engine-flutter-autoroll
94c4a3ee5 [camera]: Activate leak testing for sub packages (flutter/p…
64c7644 
…ackages#8353)
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Jan 13, 2025
@engine-flutter-autoroll
Roll Packages from 65547511c004 to 3c3bc6832b39 (16 revisions) (#161515)
72db8f6 
flutter/packages@6554751...3c3bc68

2025-01-11 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump the test-dependencies group across 2 directories with
1 update (flutter/packages#8412)
2025-01-11 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump org.json:json from 20241224 to 20250107 in
/packages/in_app_purchase/in_app_purchase_android/example/android/app
(flutter/packages#8411)
2025-01-11 [email protected] Roll Flutter from
4b23b81 to 864d4f5 (50 revisions) (flutter/packages#8408)
2025-01-10 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump org.json:json from 20240303 to 20250107 in
/packages/in_app_purchase/in_app_purchase_android/android
(flutter/packages#8413)
2025-01-10 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump org.json:json from 20241224 to 20250107 in
/packages/in_app_purchase/in_app_purchase/example/android/app
(flutter/packages#8410)
2025-01-10 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump io.mockk:mockk from 1.13.13 to 1.13.14 in
/packages/pigeon/platform_tests/test_plugin/android
(flutter/packages#8357)
2025-01-10 [email protected] Fix dependabot test-dependencies group
io.mockk regex (flutter/packages#8406)
2025-01-10 49699333+dependabot[bot]@users.noreply.github.com
[shared_pref]: Bump androidx.datastore:datastore from 1.0.0 to 1.1.1 in
/packages/shared_preferences/shared_preferences_android/android
(flutter/packages#7306)
2025-01-10 [email protected] [url_launcher_windows] Correct logging url
(flutter/packages#8107)
2025-01-10 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump io.mockk:mockk from 1.13.13 to 1.13.14 in
/packages/shared_preferences/shared_preferences_android/android
(flutter/packages#8358)
2025-01-10 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump the androidx group across 3 directories with 1 update
(flutter/packages#8329)
2025-01-10 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump org.json:json from 20240303 to 20241224 in
/packages/in_app_purchase/in_app_purchase_android/example/android/app
(flutter/packages#8372)
2025-01-10 [email protected] [url_launcher][web] Better support for
semantics in the Link widget (flutter/packages#6711)
2025-01-10 [email protected] [camera]:
Activate leak testing for sub packages (flutter/packages#8353)
2025-01-09 [email protected]
[camera_android_camerax] Remove logic used to previously correct preview
rotation (flutter/packages#8256)
2025-01-09 [email protected] [go_router]
Rephrases readme to better describe the current status
(flutter/packages#8403)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
maheshj01 pushed a commit to maheshj01/flutter that referenced this pull request Jan 15, 2025
@engine-flutter-autoroll @maheshj01
Roll Packages from 65547511c004 to 3c3bc6832b39 (16 revisions) (flutt…
8902225 
…er#161515)

flutter/packages@6554751...3c3bc68

2025-01-11 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump the test-dependencies group across 2 directories with
1 update (flutter/packages#8412)
2025-01-11 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump org.json:json from 20241224 to 20250107 in
/packages/in_app_purchase/in_app_purchase_android/example/android/app
(flutter/packages#8411)
2025-01-11 [email protected] Roll Flutter from
4b23b81 to 864d4f5 (50 revisions) (flutter/packages#8408)
2025-01-10 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump org.json:json from 20240303 to 20250107 in
/packages/in_app_purchase/in_app_purchase_android/android
(flutter/packages#8413)
2025-01-10 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump org.json:json from 20241224 to 20250107 in
/packages/in_app_purchase/in_app_purchase/example/android/app
(flutter/packages#8410)
2025-01-10 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump io.mockk:mockk from 1.13.13 to 1.13.14 in
/packages/pigeon/platform_tests/test_plugin/android
(flutter/packages#8357)
2025-01-10 [email protected] Fix dependabot test-dependencies group
io.mockk regex (flutter/packages#8406)
2025-01-10 49699333+dependabot[bot]@users.noreply.github.com
[shared_pref]: Bump androidx.datastore:datastore from 1.0.0 to 1.1.1 in
/packages/shared_preferences/shared_preferences_android/android
(flutter/packages#7306)
2025-01-10 [email protected] [url_launcher_windows] Correct logging url
(flutter/packages#8107)
2025-01-10 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump io.mockk:mockk from 1.13.13 to 1.13.14 in
/packages/shared_preferences/shared_preferences_android/android
(flutter/packages#8358)
2025-01-10 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump the androidx group across 3 directories with 1 update
(flutter/packages#8329)
2025-01-10 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump org.json:json from 20240303 to 20241224 in
/packages/in_app_purchase/in_app_purchase_android/example/android/app
(flutter/packages#8372)
2025-01-10 [email protected] [url_launcher][web] Better support for
semantics in the Link widget (flutter/packages#6711)
2025-01-10 [email protected] [camera]:
Activate leak testing for sub packages (flutter/packages#8353)
2025-01-09 [email protected]
[camera_android_camerax] Remove logic used to previously correct preview
rotation (flutter/packages#8256)
2025-01-09 [email protected] [go_router]
Rephrases readme to better describe the current status
(flutter/packages#8403)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparrishMines bparrishMines bparrishMines approved these changes

@cbracken cbracken Awaiting requested review from cbracken cbracken is a code owner

@hellohuanlin hellohuanlin Awaiting requested review from hellohuanlin hellohuanlin is a code owner

@camsim99 camsim99 Awaiting requested review from camsim99 camsim99 is a code owner

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: camera platform-android platform-ios platform-macos platform-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ValentinVignal @bparrishMines @polina-c