Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : Card text renderflex overflowed #8399

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

berhili098
Copy link

This pull request includes several changes to the packages/animations/example/lib/container_transition.dart file to improve code readability and text layout within the UI components. The most important changes are grouped into formatting improvements and UI enhancements.

Formatting Improvements:

  • Simplified the _loremIpsumParagraph constant by merging the string into a single line.
  • Reformatted the OpenContainerTransformDemo class definition to fit within a single line.
  • Adjusted the ternary operator formatting within the _OpenContainerTransformDemoState class for better readability.

UI Enhancements:

  • Wrapped Text widgets in Flexible widgets and added maxLines and TextOverflow.ellipsis properties to ensure text does not overflow and is truncated appropriately within _ExampleCard, _SmallerCard, and _ExampleSingleTile classes. [1] [2] [3]

@berhili098 berhili098 requested a review from goderbauer as a code owner January 9, 2025 11:07
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

.textTheme
.bodyMedium!
.copyWith(color: Colors.black54),
child: Flexible(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will crash since Padding is not a valid ancestor for a Flexible widget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants