Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
bug: context missing from EventsToRegister
Browse files Browse the repository at this point in the history
Problem: the custom scheduler plugin interface now
requires a context variable (which is empty/not used)
Solution: add context.Context for it.

Signed-off-by: vsoch <[email protected]>
vsoch committed Dec 8, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
1 parent 29f411e commit 4eac550
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sig-scheduler-plugins/pkg/fluence/fluence.go
Original file line number Diff line number Diff line change
@@ -140,7 +140,7 @@ func (fluence *Fluence) Name() string {

// Fluence has added delete, although I wonder if update includes that signal
// and it's redundant?
func (fluence *Fluence) EventsToRegister() []framework.ClusterEventWithHint {
func (fluence *Fluence) EventsToRegister(_ context.Context) []framework.ClusterEventWithHint {
// To register a custom event, follow the naming convention at:
// https://git.k8s.io/kubernetes/pkg/scheduler/eventhandlers.go#L403-L410
podGroupGVK := fmt.Sprintf("podgroups.v1alpha1.%v", scheduling.GroupName)

0 comments on commit 4eac550

Please sign in to comment.