feat: grow/shrink support for fluxion #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsoch
force-pushed
the
add-grow-support
branch
2 times, most recently
from
e4c421b to
78bec86
Compare
This changeset exposes the (WIP) API to allow a resource graph to grow, which needs to be a call to the c api "grow" that gets passed to unpack_at. This is a WIP because the container build has a custom clone/build of flux-sched with the grow-api branch, and we will need to eventually update that. Signed-off-by: vsoch <[email protected]>
vsoch
force-pushed
the
add-grow-support
branch
from
78bec86 to
9d3e31a
Compare
|
Note that the tests can't pass here because they aren't using the PR branch. They pass locally. |
This currently uses a custom branch, and will need to be updated when merged into flux-sched. This last change updates the CI to use the latest noble image, and adds back the shrink support and test. Signed-off-by: vsoch <[email protected]>
vsoch
force-pushed
the
add-grow-support
branch
from
b35b382 to
c9e180e
Compare
I tested having multiple contexts, but cancel issued an error and I did not think now was worth trying to debug. Signed-off-by: vsoch <[email protected]>
vsoch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset exposes the (WIP) API to allow a resource graph to grow, which needs to be a call to the c api "grow" that gets passed to unpack_at. This is a WIP because the container build has a custom clone/build of flux-sched with the grow-api branch, and we will need to eventually update that.
Note that the test isn't currently working (and will fail) but I'm opening the PR to see the changed files easily.