Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rfc20: drop the attributes section #402

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

garlick
Copy link
Member

@garlick garlick commented Nov 8, 2023

Problem: the Rv1 attributes section is used by the early Fluxion queue implementation to store the assigned queue name in the system.scheduler key, but queues are now handled differently per RFC 33.

Drop the attributes section as discussed in #401

Problem: the Rv1 attributes section is used by the early Fluxion
queue implementation to store the assigned queue name in the
system.scheduler key, but queues are now handled differently per
RFC 33.

Drop the attributes section.
@grondo
Copy link
Contributor

grondo commented Nov 8, 2023

In case it wasn't clear in #401, this section is still required by Fluxion for multi-queue restart (on restart presumably Fluxion does not have access to jobspec to get the queue name, which for some reason it needs). I'll open an issue in flux-sched and refer to this PR.

@garlick
Copy link
Member Author

garlick commented Nov 8, 2023

Yes that is what I was thinking. Move RFCs forward, let code catch up. And it should have access to the jobspec...oh maybe you meant in the place where it's using the queue name.

@grondo
Copy link
Contributor

grondo commented Nov 8, 2023

FYI: flux-framework/flux-sched#1108

@grondo
Copy link
Contributor

grondo commented Nov 8, 2023

And it should have access to the jobspec...oh maybe you meant in the place where it's using the queue name.

Yeah, I'm guessing this is in the scheduler "hello" protocol. I think only R objects are returned by this protocol. Stashing the queue name in R may have been an optimization to avoid fetching the jobspec for every R? (I actually don't know, just guessing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants