rfc27: support partial hello responses #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grondo
approved these changes
Nov 15, 2024
garlick
force-pushed
the
rfc27_partial_hello
branch
from
16c5c4c to
98e84e6
Compare
|
After feedback from @trws, the |
Problem: when resources are partially allocated across a scheduler reload, the HELLO protocol has no way to inform the scheduler which resources of the job are allocated or freed. Add an optional "free" idset key to the response. If the key is present, the ranks in the idset should be considered free. See also: flux-framework/flux-core#6089
Problem: there is no way for the scheduler to indicate that it
can handle the new 'free' key in hello responses.
The scheduler can put {"partial-ok":true} in the hello request
to indicate this.
garlick
force-pushed
the
rfc27_partial_hello
branch
from
98e84e6 to
b7b1284
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
partial-okflag to the hello request, and (if that flag was true) an optionalallocatedidset key to the response which can indicate which ranks of R are allocated when some of the ranks have already been released.The problem has been discussed in flux-framework/flux-core#6089