rfc7: break long test expressions to one per line #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chu11
force-pushed
the
rfc7_c_test_expressions
branch
from
35f349e to
3b06745
Compare
garlick
approved these changes
Dec 2, 2024
spec_7.rst
Outdated
Comment on lines
96
to
97
| && (out->bytes > MIN_BYTES | ||
| && out->bytes <= MAX_BYTES)) { |
There was a problem hiding this comment.
er that doesn't appear to be at the same indent level?
There was a problem hiding this comment.
note the parens, its style is if (A && (B &&C)) leading to the longer version
if (long-test-1
&& (long-test-2
&& long-test-3)) {
}
i added it to demonstrate that a long expression within an expression should also be broken up.
There was a problem hiding this comment.
Oh sorry, I misread that.
However, do we want that? I would not have put a line break on the second (compound) expression.
There was a problem hiding this comment.
ok, lets tweak for this example. I changed it to
+ if (out->type == MY_EXPECTED_TYPE
+ && out->bytes > LOW_END_RANGE
+ && out->bytes < HIGH_END_RANGE) {
+ ...
+ }
Problem: We've adopted a defacto guideline that long test expressions connected by "AND" or "OR" operators should be broken to one test expression per line. This is not documented. Add this to RFC 7.
chu11
force-pushed
the
rfc7_c_test_expressions
branch
from
3b06745 to
11aa0bc
Compare
|
re-pushed, tweaking the example per conversation above |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: We've adopted a defacto guideline that long test expressions connected by "AND" or "OR" operators should be broken to one test expression per line. This is not documented.
Add this to RFC 7.