-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve "flux resume" error message on non-existent object #5146
Improve "flux resume" error message on non-existent object #5146
Conversation
@sjorsholtrop-ritense Please sign the commit with |
Signed-off-by: Sjors Holtrop <[email protected]>
7edf2e6
to
8b10a32
Compare
Done! |
|
Signed-off-by: Sjors Holtrop <[email protected]>
b591582
to
3478fe3
Compare
@sjorsholtrop-ritense the file from the diff I posted above is |
Signed-off-by: Sjors Holtrop <[email protected]>
I see. I was checking the list before resources were fetched. It should be fixed now. |
Signed-off-by: Sjors Holtrop <[email protected]>
Thanks @sjorsholtrop-ritense ! |
Currently, doing a resume operation on non-existent objects, e.g.
flux resume helmrelease foo bar baz
results in the error:
This message could be more helpful. Additionally, when resuming only a single resource, the error message is slightly misleading as there might exist
HelmRelease
objects, just not the ones your provided.With this PR, the output would become:
This error message is more descriptive and follows the same format as the one in
cmd/flux/get.go:187
.