-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resource page update to include external articles/blogs #1749
Conversation
@thisisobate Can you explain some of the javascript code changes? I see that you mentioned them in your todo list but I'm not understanding what the search code changes are for. There doesn't seem to be any search on the resources page. |
So here's a brief summary of how I implemented the filter: So the filter functions as a search under the hood. The idea is that once a user selects the items to filter, it will now query the index to see if there's a match. If true, it returns the matched record and then renders it on the DOM. While thinking about this problem, I considered alot of things like internalization and advanced search capabilities. I then decided to use the Lunrjs search package to power the resource filter. |
Thanks! I think this looks good, but I can't merge it myself. As soon as someone else is able to review it, I think it's LGTM |
3901211
to
15226ee
Compare
I would like to rebase and merge this soon. If any objections, please speak up. Targeting merge later on today. We can use it to promote the Botkube and Flux integration post that @mashby2022 is planning, but I see no issues with merging this as-is (I will rebase it first, preserving the commit authorship as much as possible.) Thanks again @thisisobate ! And thanks to the CNCF team at large |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @thisisobate and @kingdonb 🏅
Signed-off-by: thisisobate <[email protected]>
Signed-off-by: thisisobate <[email protected]>
Signed-off-by: thisisobate <[email protected]>
Signed-off-by: thisisobate <[email protected]>
Signed-off-by: thisisobate <[email protected]>
Signed-off-by: thisisobate <[email protected]>
Signed-off-by: thisisobate <[email protected]>
Signed-off-by: thisisobate <[email protected]>
Signed-off-by: thisisobate <[email protected]>
Signed-off-by: thisisobate <[email protected]>
Signed-off-by: thisisobate <[email protected]>
Signed-off-by: thisisobate <[email protected]>
Signed-off-by: thisisobate <[email protected]>
Signed-off-by: thisisobate <[email protected]>
15226ee
to
306b4a3
Compare
Hi @kingdonb @stefanprodan |
We looked into it, there is a backport label that needs to be applied, I haven't been merging a lot of PRs to the website since GA so I did not know about it... You can see the result of the merge on: I'll figure out the backporting labels today so that it makes it to FluxCD.io proper - this is a user error problem and it's my problem 😅 |
Oh...thought as much 😅 |
Successfully created backport PR for |
That worked, it's deployed live and you can see it now: 🚀 🎉 |
Rebased from:
To address the Flux request for CNCF tech docs team, in cncf/techdocs#192
Thank you @thisisobate!