Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] add driverPod/executorPod in Spark #6085

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

fix: based on suggested change

48902c9
Select commit
Loading
Failed to load commit list.
Open

[FEAT] add driverPod/executorPod in Spark #6085

fix: based on suggested change
48902c9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 28, 2024 in 0s

37.01% (-0.09%) compared to ba331fd

View this Pull Request on Codecov

37.01% (-0.09%) compared to ba331fd

Details

Codecov Report

Attention: Patch coverage is 58.20896% with 28 lines in your changes missing coverage. Please review.

Project coverage is 37.01%. Comparing base (ba331fd) to head (48902c9).
Report is 36 commits behind head on master.

Files with missing lines Patch % Lines
flyteplugins/go/tasks/plugins/k8s/spark/spark.go 71.42% 10 Missing and 4 partials ⚠️
flyteidl/gen/pb-go/flyteidl/plugins/spark.pb.go 0.00% 10 Missing ⚠️
...ns/go/tasks/pluginmachinery/flytek8s/pod_helper.go 50.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6085      +/-   ##
==========================================
- Coverage   37.10%   37.01%   -0.09%     
==========================================
  Files        1318     1318              
  Lines      132331   132578     +247     
==========================================
- Hits        49097    49078      -19     
- Misses      78961    79249     +288     
+ Partials     4273     4251      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.