[FlyteCTL Feature] save registration process results into result_dir #1904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wckdman
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
wckdman
force-pushed
the
feature/pyflyte-register-outputs
branch
from
0e382f0 to
3029470
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1904 +/- ##
===========================================
- Coverage 94.95% 51.03% -43.92%
===========================================
Files 136 171 +35
Lines 6165 16833 +10668
Branches 0 3493 +3493
===========================================
+ Hits 5854 8591 +2737
- Misses 311 7819 +7508
- Partials 0 423 +423 ☔ View full report in Codecov by Sentry. |
|
@eapolinario @pingsutw can you please review this PR? |
|
@wckdman, can you resolve the merge conflict? |
wckdman
force-pushed
the
feature/pyflyte-register-outputs
branch
from
3029470 to
025081a
Compare
|
@samhita-alla Done ✅ |
Signed-off-by: Artem Petrov <[email protected]>
wckdman
force-pushed
the
feature/pyflyte-register-outputs
branch
from
025081a to
c89ab2c
Compare
Signed-off-by: Artem Petrov <[email protected]>
wckdman
force-pushed
the
feature/pyflyte-register-outputs
branch
from
c89ab2c to
d69dd5c
Compare
|
@samhita-alla @eapolinario @pingsutw ping :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Save info about registered entities into a json/.yaml file
Type
Are all requirements met?
Complete description
WDYT about chosen arguments' names?
Tracking Issue
flyteorg/flyte#3919
Follow-up issue
NA