Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] support for cluster pools throughout the sdk #3039

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

[wip] support for cluster pools throughout the sdk #3039

wants to merge 3 commits into from

Conversation

kumare3
Copy link
Contributor

@kumare3 kumare3 commented Jan 7, 2025 •
edited
Loading

Need corresponding updates in flyteidl. They are coming soon

@flyte-bot
Copy link
Contributor

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].

kumare3 added 2 commits January 7, 2025 10:55
@kumare3
Updated, needs flyteidl change
76fe90c 
Signed-off-by: Ketan Umare <[email protected]>
@kumare3
Unit tests added
d26e348 
Signed-off-by: Ketan Umare <[email protected]>
@flyte-bot
Copy link
Contributor

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wild-endeavor wild-endeavor Awaiting requested review from wild-endeavor wild-endeavor will be requested when the pull request is marked ready for review wild-endeavor is a code owner

@eapolinario eapolinario Awaiting requested review from eapolinario eapolinario will be requested when the pull request is marked ready for review eapolinario is a code owner

@pingsutw pingsutw Awaiting requested review from pingsutw pingsutw will be requested when the pull request is marked ready for review pingsutw is a code owner

@cosmicBboy cosmicBboy Awaiting requested review from cosmicBboy cosmicBboy will be requested when the pull request is marked ready for review cosmicBboy is a code owner

@samhita-alla samhita-alla Awaiting requested review from samhita-alla samhita-alla will be requested when the pull request is marked ready for review samhita-alla is a code owner

@thomasjpfan thomasjpfan Awaiting requested review from thomasjpfan thomasjpfan will be requested when the pull request is marked ready for review thomasjpfan is a code owner

@Future-Outlier Future-Outlier Awaiting requested review from Future-Outlier Future-Outlier will be requested when the pull request is marked ready for review Future-Outlier is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kumare3 @flyte-bot