Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format imports better #3089

Merged
merged 1 commit into from
Jan 25, 2025
Merged

Format imports better #3089

merged 1 commit into from
Jan 25, 2025

Conversation

wild-endeavor
Copy link
Contributor

@wild-endeavor wild-endeavor commented Jan 25, 2025

An import was accidentally removed (because it was a duplicate in the commit that was cherry-picked). Adding it back and formatting better.

Summary by Bito

Import statements in test_dataclass.py have been reorganized for better code organization. The changes include removing duplicate imports, restoring a previously removed DataClassJsonMixin import, and grouping related imports together in a more structured manner.

Unit tests added: False

Estimated effort to review (1-5, lower is better): 1

Signed-off-by: Yee Hing Tong <[email protected]>
@flyte-bot
Copy link
Contributor

flyte-bot commented Jan 25, 2025

Code Review Agent Run #01b341

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: 05678c2..05678c2
    • tests/flytekit/unit/core/test_dataclass.py
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • MyPy (Static Code Analysis) - ✔︎ Successful
    • Astral Ruff (Static Code Analysis) - ✔︎ Successful

AI Code Review powered by Bito Logo

@flyte-bot
Copy link
Contributor

Changelist by Bito

This pull request implements the following key changes.

Key Change Files Impacted
Other Improvements - Import Statement Reorganization

test_dataclass.py - Reorganized and restored import statements for better code organization

@wild-endeavor wild-endeavor merged commit e1d2815 into release-v1.14 Jan 25, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants