[WIP] Rename ephemeral_storage to disk for simplicity #3095
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
flyteorg/flyte#6142
Why are the changes needed?
The attribute
ephemeral_storage
ofResources
(i.e., K8s pod resources) is too complicated and should be simplfied.What changes were proposed in this pull request?
At this stage, we propose supporting both
disk
andephemeral_storage
with the following behavior:ephemeral_storage
will remain supported as an alias for backward compatibility and developer-facing codedisk
for future configurationsThe behavior for different configurations is summarized as follows:
disk
andephemeral_storage
are specified: Raise an error to avoid ambiguityephemeral_storage
is specified: Issue a warning about future deprecation but continue to use it as isdisk
is specified: Automatically setephemeral_storage
to the value ofdisk
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link