Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Rename ephemeral_storage to disk for simplicity #3095

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JiangJiaWei1103
Copy link
Contributor

Tracking issue

flyteorg/flyte#6142

Why are the changes needed?

The attribute ephemeral_storage of Resources (i.e., K8s pod resources) is too complicated and should be simplfied.

What changes were proposed in this pull request?

At this stage, we propose supporting both disk and ephemeral_storage with the following behavior:

  1. ephemeral_storage will remain supported as an alias for backward compatibility and developer-facing code
  2. Users are encouraged to adopt disk for future configurations

The behavior for different configurations is summarized as follows:

  1. Both disk and ephemeral_storage are specified: Raise an error to avoid ambiguity
  2. Only ephemeral_storage is specified: Issue a warning about future deprecation but continue to use it as is
  3. Only disk is specified: Automatically set ephemeral_storage to the value of disk

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

1. Support `ephemeral_storage` as an alias for backward compatibility
    and developer-facing code
2. Encourage users to switch to `disk` when configuring this property

Signed-off-by: JiangJiaWei1103 <[email protected]>
@flyte-bot
Copy link
Contributor

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

2 participants