Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some missing documentation #97

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Add some missing documentation #97

merged 1 commit into from
Jul 10, 2023

Conversation

tchajed
Copy link
Collaborator

@tchajed tchajed commented Jul 7, 2023

For updr I made fewer things public and then didn't document the private items (I don't understand the code well enough to add that documentation in any case).

@tchajed tchajed force-pushed the add-more-docs branch 2 times, most recently from 19bcda9 to ba36155 Compare July 7, 2023 21:57
@Alex-Fischman
Copy link
Collaborator

Is this branch intended to completely resolve #95, or just part of it?

@tchajed
Copy link
Collaborator Author

tchajed commented Jul 7, 2023

It's only part of it. @edenfrenkel will have to write the documentation for most of the inference code.

For updr I made fewer things public and then didn't document the private
items (I don't understand the code well enough to add that documentation
in any case).

Signed-off-by: Tej Chajed <[email protected]>
@tchajed tchajed merged commit 99fda4f into main Jul 10, 2023
@tchajed tchajed deleted the add-more-docs branch July 10, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants