Optimized application-defined functions #1251

trueqbit · 2023-11-25T20:36:37Z

This PR contains the following improvements and optimizations to application-defined functions

Application-defined function names can now contain spaces or quotation marks
Move-capture construction arguments for traditional application-defined functions
Reorganized dispatch-based sqlite function callbacks to direct calls
Traditional stateless application-defined functions are constructed only once
Runtime check of the number of function arguments replaced by a runtime assertion

dev/udf_proxy.h

trueqbit added 10 commits November 25, 2023 08:44

Merge remote-tracking branch 'upstream/dev' into feature/generalized_udf

64977e6

Create a stateless user-defined function only once

65e2c4a

Function identifiers may contain spaces or quotation marks.

ecc971d

Direct call of quoted scalar function

7be2a4d

Direct call of scalar/step functions

c238e41

Move-capture construction arguments for user-defined functions

7377177

Considered user-defined function name() returning a string view

2cac29e

Simplified unit test for escaped scalar function name

6bde0ac

Correct unit test that serializes a function name

574d30f

Runner-up: Corrected unit tests that serialize function names

f67816c

trueqbit requested a review from fnc12 November 25, 2023 22:07

fnc12 approved these changes Nov 26, 2023

View reviewed changes

dev/udf_proxy.h Show resolved Hide resolved

trueqbit merged commit 32c4cb9 into fnc12:dev Nov 26, 2023
1 check passed

trueqbit deleted the feature/optimized_udf branch November 26, 2023 08:33

Provide feedback