MCBFF-51 Populate staff slip context for non-DCB items #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…viceImpl.java Co-authored-by: Roman Barannyk <[email protected]>
roman-barannyk
force-pushed
the
MCBFF-51
branch
from
a3a870f to
64c9a2b
Compare
…on-bff into MCBFF-51 # Conflicts: # src/main/java/org/folio/circulationbff/service/impl/CheckInServiceImpl.java
alexanderkurash
approved these changes
Jan 31, 2025
src/main/java/org/folio/circulationbff/service/impl/CheckInServiceImpl.java
Show resolved
Hide resolved
src/main/java/org/folio/circulationbff/service/impl/CheckInServiceImpl.java
Outdated
Show resolved
Hide resolved
roman-barannyk
force-pushed
the
MCBFF-51
branch
from
163825a to
ee75153
Compare
src/main/java/org/folio/circulationbff/service/impl/CheckInServiceImpl.java
Outdated
Show resolved
Hide resolved
OleksandrVidinieiev
approved these changes
Jan 31, 2025
src/main/java/org/folio/circulationbff/service/impl/CheckInServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/org/folio/circulationbff/service/impl/CheckInServiceImpl.java
Outdated
Show resolved
Hide resolved
roman-barannyk
force-pushed
the
MCBFF-51
branch
from
08338ea to
594ee45
Compare
alexanderkurash
changed the title
roman-barannyk
force-pushed
the
MCBFF-51
branch
2 times, most recently
from
d17a34c to
dded9e8
Compare
roman-barannyk
force-pushed
the
MCBFF-51
branch
from
dded9e8 to
5a901d6
Compare
|
roman-barannyk
added a commit
that referenced
this pull request
Feb 3, 2025
* MCBFF-38: Update hardcoded effective location during checkin * MCBFF-38: fix search query * MCBFF-38: removed empty lines, added permissions, fixed duplicate logging * MCBFF-38: given-when-then comments removed * MCBFF-38: fix fetching service point by location id * Update src/main/java/org/folio/circulationbff/service/impl/CheckInServiceImpl.java Co-authored-by: Roman Barannyk <[email protected]> * MCBFF-38: fix build * MCBFF-51 populate staff slips context for not DCB item * MCBFF-51 fix broken tests * MCBFF-51 fix broken tests, refactoring * MCBFF-51 add test * MCBFF-51 add contributor to searchInstance * MCBFF-51 add permissions * MCBFF-51 add slips checks * MCBFF-51 fix dcb item check * MCBFF-51 update logic * MCBFF-51 fix test * MCBFF-51 add test * MCBFF-51 add location-units interface dependency * MCBFF-51 refactoring * MCBFF-51 rename method * MCBFF-51 update logs * MCBFF-51 Refactor check in service * MCBFF-51 update logging * MCBFF-51 update formatContributorNames * MCBFF-51 incorporating review comments * MCBFF-51 rename method * MCBFF-51 add permissions, update logging --------- Co-authored-by: Irakli Merabishvili <[email protected]> Co-authored-by: imerabishvili <[email protected]> Co-authored-by: alexanderkurash <[email protected]> (cherry picked from commit a91c15f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In transit and Hold slips in ECS Eureka environments are missing key tokens when printed from the central tenant.
Resolves: MCBFF-51