Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(specification-subfields-validation) implement "Missing Subfield" Rule Validation #61

Merged
merged 4 commits into from
Sep 4, 2024
Merged

feat(specification-subfields-validation) implement "Missing Subfield" Rule Validation #61

merged 4 commits into from
Sep 4, 2024

Conversation

SvitlanaKovalova1
Copy link
Contributor

@SvitlanaKovalova1 SvitlanaKovalova1 commented Sep 3, 2024 •
edited
Loading

Purpose

MRSPECS-47 Implement "Missing Subfield" Rule Validation

Approach

Validation fails when subfield is required but does not exist in a record's field

Changes Checklist

  • API Changes: Document any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Indicate any database schema changes and their impact. Confirm that migration scripts were created.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Document added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • Unit Testing: Confirm that changed classes were covered by unit tests.
  • Integration Testing: Confirm that changed logic was covered by integration tests.
  • Manual Testing: Confirm that changes were tested on local or dev environment.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

@SvitlanaKovalova1 SvitlanaKovalova1 marked this pull request as ready for review September 3, 2024 15:19
@SvitlanaKovalova1 SvitlanaKovalova1 requested a review from a team as a code owner September 3, 2024 15:19
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@SvitlanaKovalova1 SvitlanaKovalova1 merged commit d682946 into master Sep 4, 2024
6 checks passed
@SvitlanaKovalova1 SvitlanaKovalova1 deleted the MRSPECS-47 branch September 4, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psmagin psmagin psmagin approved these changes

@mukhiddin-yusuf mukhiddin-yusuf mukhiddin-yusuf approved these changes

@viacheslavkol viacheslavkol Awaiting requested review from viacheslavkol viacheslavkol is a code owner automatically assigned from folio-org/spitfire-backend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SvitlanaKovalova1 @psmagin @mukhiddin-yusuf