Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(specification-storage): implement endpoints to manage field definitions #7

Merged
merged 16 commits into from
Jun 11, 2024
Merged

feat(specification-storage): implement endpoints to manage field definitions #7

merged 16 commits into from
Jun 11, 2024

Conversation

psmagin
Copy link
Collaborator

@psmagin psmagin commented May 22, 2024 •
edited
Loading

Purpose

Create endpoints to mange field definitions:

  • create field definition for specification
  • get all specification's field definitions
  • update field definition
  • delete field definition

Approach

  • develop API definitions
  • develop migration scripts for field table creation
  • implemented logic for the endpoints
  • added localization support and refactor error handling using localization service

Changes Checklist

  • API Changes: Document any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Indicate any database schema changes and their impact. Confirm that migration scripts were created.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Document added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • Unit Testing: Confirm that changed classes were covered by unit tests.
  • Integration Testing: Confirm that changed logic was covered by integration tests.
  • Manual Testing: Confirm that changes were tested on local or dev environment.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

Related Issues

https://folio-org.atlassian.net/browse/MRSPECS-6

@psmagin psmagin force-pushed the MRSPECS-6 branch 2 times, most recently from e446a04 to 968941f Compare June 4, 2024 09:28
@psmagin psmagin changed the title Mrspecs 6 feat(specification-storage): implement endpoints to manage field definitions Jun 7, 2024
@psmagin psmagin self-assigned this Jun 7, 2024
@psmagin psmagin marked this pull request as ready for review June 7, 2024 13:39
@psmagin psmagin requested a review from a team as a code owner June 7, 2024 13:39
@psmagin psmagin requested a review from viacheslavkol June 11, 2024 10:24
@psmagin psmagin requested a review from mukhiddin-yusuf June 11, 2024 10:24
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@psmagin psmagin merged commit fc7ded6 into master Jun 11, 2024
8 checks passed
@psmagin psmagin deleted the MRSPECS-6 branch June 11, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viacheslavpoliakov viacheslavpoliakov viacheslavpoliakov approved these changes

@viacheslavkol viacheslavkol viacheslavkol approved these changes

@mukhiddin-yusuf mukhiddin-yusuf Awaiting requested review from mukhiddin-yusuf

Assignees

@psmagin psmagin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@psmagin @viacheslavkol @mukhiddin-yusuf @viacheslavpoliakov