Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MRSPECS-59: implement LCCN subfield validation #79

Merged
merged 13 commits into from
Oct 10, 2024
Merged

MRSPECS-59: implement LCCN subfield validation #79

merged 13 commits into from
Oct 10, 2024

Conversation

mukhiddin-yusuf
Copy link
Contributor

@mukhiddin-yusuf mukhiddin-yusuf commented Oct 4, 2024 •
edited
Loading

Purpose

Add validation for the LCCN: 010 $a value

Approach

  • add a rule and make it disabled by default
  • add implementation of the validation rule

Changes Checklist

  • API Changes: Document any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Indicate any database schema changes and their impact. Confirm that migration scripts were created.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Document added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • Unit Testing: Confirm that changed classes were covered by unit tests.
  • Integration Testing: Confirm that changed logic was covered by integration tests.
  • Manual Testing: Confirm that changes were tested on local or dev environment.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

Related Issues

MRSPECS-59

@mukhiddin-yusuf mukhiddin-yusuf self-assigned this Oct 4, 2024
@mukhiddin-yusuf mukhiddin-yusuf requested a review from a team as a code owner October 4, 2024 07:15
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mukhiddin-yusuf mukhiddin-yusuf merged commit 16d0f64 into master Oct 10, 2024
6 checks passed
@mukhiddin-yusuf mukhiddin-yusuf deleted the mrspecs-59 branch October 10, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viacheslavkol viacheslavkol viacheslavkol approved these changes

@psmagin psmagin psmagin approved these changes

@SvitlanaKovalova1 SvitlanaKovalova1 Awaiting requested review from SvitlanaKovalova1 SvitlanaKovalova1 is a code owner automatically assigned from folio-org/spitfire-backend

Assignees

@mukhiddin-yusuf mukhiddin-yusuf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mukhiddin-yusuf @psmagin @viacheslavkol