-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STCLI-259 provide transpile #368
Open
zburke
wants to merge
4
commits into
master
Choose a base branch
from
STRIPES-957
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the `transpile` command implmented in #259 (STCLI-224), which transpiled and bundled with help from stripes-cli, with one that only conducts transpilation. ``` yarn stripes transpile yarn stripes transpile --path ./lib ``` The default `path` is `./src`. Files are transpiled into `./dist`. Sourcemaps are included. Non-compilable files (e.g. `.css`) are copied into the destination directory. All dependencies and babel config files are included locally. The intent is to provide a canonical service, much as stripes-webpack has in the past, so the packages using this service do not have to worry about managing dependencies or config files. The babel config is contained in `./lib/commands/transpile-babel.config.json`: ``` { "presets": [ ["@babel/preset-env", { "targets": "> 0.25%, not dead", // preset-env will transform dynamic exports, but we want // to let webpack handle those "exclude": ["transform-dynamic-import"] }], ["@babel/preset-flow", { "all": true }], ["@babel/preset-react", { "runtime": "automatic" }], ["@babel/preset-typescript"] ], "plugins": [ ["@babel/plugin-proposal-decorators", { "legacy": true }], // when building a platform directly, i.e. outside a workspace, // babel complains loudly and repeatedly that when these modules are enabled: // * @babel/plugin-proposal-class-properties, // * @babel/plugin-proposal-private-methods and // * @babel/plugin-proposal-private-property-in-object // the "loose" option must be the same for all three. // but @babel/preset-env sets it to false for ...private-methods. // overriding it here silences the complaint. STRWEB-12 ["@babel/plugin-transform-class-properties", { "loose": true }], ["@babel/plugin-transform-private-methods", { "loose": true }], ["@babel/plugin-transform-private-property-in-object", { "loose": true }], "@babel/plugin-transform-export-namespace-from", "@babel/plugin-proposal-function-sent", "@babel/plugin-transform-numeric-separator", "@babel/plugin-proposal-throw-expressions", "@babel/plugin-syntax-import-meta" ] } ``` Refs STCLI-259
Quality Gate failedFailed conditions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the
transpile
command implmented in #259 (STCLI-224), which transpiled and bundled with help from stripes-webpack, with one that only conducts transpilation.The default
files
value is./src
. Files are transpiled into./dist
. Sourcemaps are included. Non-compilable files (e.g..css
) are copied into the destination directory.All dependencies and babel config files are included locally. The intent is to provide a canonical service, much as stripes-webpack has in the past, so the packages using this service do not have to worry about managing dependencies or config files.
The babel config is contained in
./lib/commands/transpile-babel.config.json
:Refs STCLI-259