Skip to content

Commit

Permalink
Fix #2675
Browse files Browse the repository at this point in the history
  • Loading branch information
fonsp committed Oct 27, 2023
1 parent 292c881 commit e97616f
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/evaluation/Run.jl
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ function run_reactive_core!(
relay_reactivity_error!(cell, error)
end

# Save the notebook. This is the only time that we save the notebook, so any state changes that influence the file contents (like `depends_on_disabled_cells`) should be behind this point.
# Save the notebook. In most cases, this is the only time that we save the notebook, so any state changes that influence the file contents (like `depends_on_disabled_cells`) should be behind this point. (More saves might happen if a macro expansion or package using happens.)
save && save_notebook(session, notebook)

# Send intermediate updates to the clients at most 20 times / second during a reactive run. (The effective speed of a slider is still unbounded, because the last update is not throttled.)
Expand Down Expand Up @@ -220,7 +220,7 @@ function run_reactive_core!(

# update cache and save notebook because the dependencies might have changed after expanding macros
update_dependency_cache!(notebook)
save_notebook(session, notebook)
save && save_notebook(session, notebook)

return run_reactive_core!(session, notebook, new_topology, new_new_topology, to_run; save, deletion_hook, user_requested_run, already_run = to_run[1:i])
elseif !isempty(implicit_usings)
Expand All @@ -229,7 +229,7 @@ function run_reactive_core!(

# update cache and save notebook because the dependencies might have changed after expanding macros
update_dependency_cache!(notebook)
save_notebook(session, notebook)
save && save_notebook(session, notebook)

return run_reactive_core!(session, notebook, new_topology, new_new_topology, to_run; save, deletion_hook, user_requested_run, already_run = to_run[1:i])
end
Expand Down

0 comments on commit e97616f

Please sign in to comment.