Use <dialog> for the export menu for better keyboard accessibility #2750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fonsp
added
frontend
Try this Pull Request!Open Julia and type: julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="export-menu-dialog-semantics")
julia> using Pluto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The export menu used to be an
<aside>, usinginertand styling when the menu is toggled. This PR changes it to<dialog>withopen(not modal), which is better semantics that will also make sure that the correct tabbing behaviour is achieved. The menu is also closed when focus is lost.This matches the expected behaviour, like in https://webaim.org/resources/htmlcheatsheet/ or https://webaim.org/techniques/keyboard/
In the video below, I use the Tab, Enter and Escape keys:
Schermopname.2023-12-12.om.10.11.18.mov