◐ Spin Pkg terminal spinners with CSS for performance #2787
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2500 introduced two performance issues:
The solution in this PR is to replace all 4 progress characters with
◐
on the server side (before diffing). This fixes both issues because the updates are now much less frequent.To still get a spinning animation, we search for the
◐
character, give it a class and make it spin with a CSS animation. The result is almost identical!Before
Schermopname.2024-01-22.om.11.06.57.mov
After
Schermopname.2024-01-22.om.11.27.16.mov
You can see that there are much fewer messages from the server:
Schermopname.2024-01-22.om.11.33.11.mov
fix #2739