Initial setup of filterbox on popover. #10
Conversation
Did PairFilterBox pretty quick, open to refactors. Styling's very basic; good-enough?
There was a problem hiding this comment.
Thank you for your contribution, @trigunshin! Works perfectly as far as I can tell.
I'm not a 100% sure of the code setup: storing state in the search input component seems un-Reduxy. Is it the best approach here?
| constructor(props) { | ||
| super(props); | ||
| this.state = {filterText: ''}; | ||
| this.onStateChange = this.onStateChange.bind(this); |
There was a problem hiding this comment.
Consider using funcName = () => {} at class level?
|
I think we're on the right track UI-wise. I've thrown a bit of styling overtop the component, seen above. Does it look right to you? Styling as seen:
|
|
I can move the filterstate into redux, sure. Initially I wasn't sure that it'd need the wider scope, but being able to share the filter/selection from the popover box to any other select dialog would be kind of nice. I should get some time for that tomorrow afternoon. |
Did PairFilterBox pretty quick, open to refactors.
Styling's very basic; good-enough?