Skip to content
This repository has been archived by the owner on Mar 3, 2019. It is now read-only.

[WIP] Initial commit for dockerizing frontend #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] Initial commit for dockerizing frontend #16

wants to merge 1 commit into from

Conversation

bbasseri
Copy link

Initial work for making the front-end Dockerized with Docker-compose. @freeatnet

Copy link
Contributor

@freeatnet freeatnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paths and copying above look a bit uncoordinated. It looks like we're running the app from /usr/src, but copying package.json, yarn.lock and installing node modules at the root. That should probably go into the same location.

@@ -0,0 +1 @@
node_modules
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,21 @@
FROM node:8
Copy link
Contributor

@freeatnet freeatnet Mar 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it be done with the alpine version?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants