-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: configure comment and release pipelines #1154
Conversation
Reviewer's Guide by SourceryThis PR configures two new GitHub Actions workflows: one for commenting on pull requests with the debug APK, and another for automating releases. Sequence diagram for PR comment workflowsequenceDiagram
participant PR as Pull Request
participant CI as Badge Magic PR CI
participant Comment as Comment Workflow
participant GH as GitHub API
PR->>CI: PR Created/Updated
CI->>CI: Build APK
CI->>CI: Save PR number
CI->>CI: Upload artifacts
CI-->>Comment: Workflow completed
Comment->>GH: Download PR number artifact
alt Build Success
Comment->>GH: Download APK artifact
Comment->>GH: Check existing comments
alt Existing bot comment
Comment->>GH: Update comment with APK link
else No existing comment
Comment->>GH: Create new comment with APK link
end
else Build Failure
Comment->>GH: Check existing comments
alt Existing bot comment
Comment->>GH: Update comment with failure
else No existing comment
Comment->>GH: Create new comment with failure
end
end
Sequence diagram for release workflowsequenceDiagram
participant GH as GitHub Release
participant Release as Release Workflow
participant Fastlane as Fastlane Branch
participant Play as Play Store
GH->>Release: Release Published
Release->>Release: Download release assets
Release->>Release: Generate screenshots
Release->>Fastlane: Update metadata & changelogs
Release->>Fastlane: Update screenshots
Release->>Fastlane: Force push changes
Release->>Play: Promote version to production
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @AsCress - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
.github/workflows/release.yml
Outdated
- name: Download repository | ||
uses: actions/checkout@v4 | ||
|
||
- name: Prepare Build Keys |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to prepare keys?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was exactly the question which came to my mind as well. I think we don't, do we ? For some reason it's there in pslab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed it.
Head branch was pushed to by a user without write access
#1153 should be merged before this!
Adds the following pipelines to our repository:
Summary by Sourcery
Add CI workflows for commenting on pull requests with APK download links upon successful builds, and for automating releases by updating changelogs, fetching screenshots, and promoting the APK to production.
CI:
Tests: