Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Invert LED mode aligns text off side of display #897

Merged
merged 1 commit into from
Apr 30, 2024
Merged

fix: Invert LED mode aligns text off side of display #897

merged 1 commit into from
Apr 30, 2024

Conversation

amrsalah3
Copy link
Contributor

Fixes #890 and #896

Changes:

  1. Fixed invert LED mode wrong alignment. In development version, it was always aligning to the left, and for Google Play version, it was aligning to the right. Now, the text with invert LED mode is centered properly.
  2. Added documentation for handleInvertLED(hexStrings, isInverted) method to help understand what it does.

Screenshots for the change:

Fix.mp4

@amrsalah3
Copy link
Contributor Author

@mariobehling Please review.

@mariobehling mariobehling requested a review from adityastic March 10, 2024 15:43
@mariobehling mariobehling merged commit 671f132 into fossasia:development Apr 30, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariobehling mariobehling mariobehling approved these changes

@adityastic adityastic Awaiting requested review from adityastic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inverted LED effect shifts content to the right
2 participants
@amrsalah3 @mariobehling