Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added prominent disclosure dialogs #931

Merged
merged 1 commit into from
May 22, 2024

Conversation

AsCress
Copy link
Contributor

@AsCress AsCress commented May 22, 2024

Fixes #928
Adds prominent disclosure dialogs for location and storage permissions. Cleans up the code a bit by migrating all permission checks to a separate kotlin class BadgeMagicPermission.kt.

Changes:

  • android/src/main/java/org/fossasia/badgemagic/others/BadgeMagicPermission.kt - Added a new kotlin class that handles all the permission checks.
  • android/src/main/java/org/fossasia/badgemagic/ui/DrawerActivity.kt

Screenshots for the change:

WhatsApp Image 2024-05-22 at 3 41 10 PM
WhatsApp Image 2024-05-22 at 3 41 11 PM
Here, is a recording for the same:
https://www.youtube.com/shorts/cV6atqGElhw

Checklist:

  • No hard coding: I have used resources from strings.xml, dimens.xml and colors.xml without hard coding any value.
  • No end of file edits: No modifications done at end of resource files strings.xml, dimens.xml or colors.xml.
  • Code reformatting: I have reformatted code and fixed indentation in every file included in this pull request.
  • No extra space: My code does not contain any extra lines or extra spaces than the ones that are necessary.

@adityastic adityastic merged commit 2b1f5a0 into fossasia:development May 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add prominent disclosure in a dialog for location
2 participants