Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generator UI reformation #123

Merged
merged 6 commits into from
May 16, 2018
Merged

Generator UI reformation #123

merged 6 commits into from
May 16, 2018

Conversation

meets2tarun
Copy link
Member

@meets2tarun meets2tarun commented May 15, 2018

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • There is a corresponding issue for this pull request. Add script to Generator and implement UI options #121
  • My branch is up-to-date with the Upstream master branch.
  • The unit tests pass locally with my changes (provide a screenshot or link for test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Short description of what this resolves:

This PR reforms UI of Meilix Generator and make it look like other FOSSASIA projects.

This PR is an initiation for UI change and several more changes needs to be done.

@meets2tarun
Copy link
Member Author

Deployed here: https://meilix-test.herokuapp.com

@niccokunzmann
Copy link
Member

Hi Tarun,

you are adding static files to the template directory.
As I understand, in this directory, we should only find files which do not have static content.
Would you like to move it to the static folder?

Please have a look here on how to include static content:
https://github.com/fossasia/meilix-generator/blob/master/templates/index.html#L12

@meets2tarun
Copy link
Member Author

Hi @niccokunzmann,
I included all the files in the template folder as I didn't use static in index.html.
Static folder is earlier used as it is required according to the code but now since the code has been changed, the old static folder has no use..

Thanks

@niccokunzmann
Copy link
Member

I do not know how a client can access the js files through flask.
Are there environment variables for this? Could you help me understand?

@niccokunzmann
Copy link
Member

https://meilix-generator.herokuapp.com/ is this the deploy link?

@niccokunzmann
Copy link
Member

Now, there is only one file changed.

@meets2tarun
Copy link
Member Author

@niccokunzmann, I made few mistakes in branch but now I corrected everything
deployed link: https://meilix-test.herokuapp.com

Copy link
Member

@niccokunzmann niccokunzmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@niccokunzmann
Copy link
Member

Can this be merged? There is this tag.

@meets2tarun
Copy link
Member Author

Yes, this can be merged!
Thanks

@niccokunzmann niccokunzmann merged commit 8076dbf into fossasia:master May 16, 2018
@niccokunzmann
Copy link
Member

Thanks!

@meets2tarun meets2tarun deleted the ui branch May 16, 2018 09:58
@fossasia-bot fossasia-bot bot added the has-PR label May 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants