Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend improvement #135

Merged
merged 2 commits into from
May 27, 2018
Merged

Frontend improvement #135

merged 2 commits into from
May 27, 2018

Conversation

meets2tarun
Copy link
Member

@meets2tarun meets2tarun commented May 26, 2018 •
edited
Loading

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • There is a corresponding issue for this pull request.
  • My branch is up-to-date with the Upstream master branch.
  • The unit tests pass locally with my changes (provide a screenshot or link for test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Fix#121

xeon-zolt
xeon-zolt reviewed May 26, 2018
View reviewed changes
templates/index.html
@@ -12,7 +12,6 @@
<link href='https://fonts.googleapis.com/css?family=Roboto:400,100' rel='stylesheet' type='text/css'>
<script src="{{ url_for('static', filename='js/jquery.min.js') }}"></script>
<script src="{{ url_for('static', filename='js/bootstrap.min.js') }}"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/js/bootstrap.min.js"></script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still thinking why we had a multiple bootstrap js

@xeon-zolt
Copy link
Member

@meets2tarun always provide with a link or screenshot for the UI changes showing what you have changed

@meets2tarun
Copy link
Member Author

@xeon-zolt Sure, I'll take care of this.

screen shot 2018-05-27 at 18 59 44

Thanks

@xeon-zolt xeon-zolt merged commit 66bb58e into fossasia:master May 27, 2018
@xeon-zolt
Copy link
Member

@meets2tarun let's focus on functionality first then we can focus on improving the UI

@meets2tarun meets2tarun deleted the front branch May 27, 2018 14:31
@meets2tarun
Copy link
Member Author

@xeon-zolt
Sure Harsh,
We have a meeting down there this Wednesday
Please do come and I propose an idea in the blog3 (discussed between me and Nicco).

@xeon-zolt
Copy link
Member

cannot come on a weekday (only available late in the evening )
what about weekend ??

@meets2tarun
Copy link
Member Author

@xeon-zolt
Give your desired time here:
https://dudle.inf.tu-dresden.de/meilix-meet-16/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeon-zolt xeon-zolt xeon-zolt approved these changes

Assignees

@meets2tarun meets2tarun

Labels
ready-to-ship
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add script to Generator and implement UI options
2 participants
@meets2tarun @xeon-zolt